Request for commit

[uvoigt]

Hi David,

could you please commit the following simple patches so that they are included in JFreeChart 1.0.19?

https://sourceforge.net/p/jfreechart/patches/311/
https://sourceforge.net/p/jfreechart/patches/307/
https://sourceforge.net/p/jfreechart/patches/304/

Thanks!
Uli

[uvoigt]

Hi David,

although it's not a simple patch I also request to commit patch https://sourceforge.net/p/jfreechart/patches/309/

Thanks!
Uli

[david.gilbert]

#304 is committed (with changes). Looking at the others.

[david.gilbert]

#307 is committed for inclusion in the 1.0.19 release.

[uvoigt]

#304 is committed (with changes). Looking at the others.

Hi David,

the changes are ok for me. Thanks!
Uli

[uvoigt]

While testing some changes for the zoom and pan improvment I found out that the entity areas are sometimes wrong for all area renderers.
Please find a patch at https://sourceforge.net/p/jfreechart/patches/312/

I think it's save to commit

Uli

[david.gilbert]

I will commit this. Do you think there will be any performance issue using the Area class for calculating the intersection? I'm hoping it is smart enough to do some special case handling when it finds that one of the shapes is a rectangle…otherwise we should make use of the fact that we know that one shape is a polygon and the other is a rectangle and write our own code to compute the intersection.

[david.gilbert]

Patch 312 is committed for inclusion in the 1.0.20 release (and also merged to the JFreeChart 2 repo on GitHub).

[uvoigt]

I will commit this. Do you think there will be any performance issue using the Area class for calculating the intersection? I'm hoping it is smart enough to do some special case handling when it finds that one of the shapes is a rectangle…otherwise we should make use of the fact that we know that one shape is a polygon and the other is a rectangle and write our own code to compute the intersection.

Thanks!

Having a look at Area.contains(x,y) shows that the Area class internally uses a cached bounds object first to check if the given point may be located within the area. So there are two additional things the Area object performs in the contains method compared to a Rectangle object:
1. initially creating the cached bounds
2. when the point is located within the cached bounds it checks again using the curves of the Area object

So there is an overhead which should be ok.
On the other hand the Area object requires much more memory than a Rectangle which is relevant for big plots.

Ulrich