rotate

[bbolstad]

Hello, I'm new to FXGraphics2D, so pardon me if I'm being dense, but is it just me, or is the rotate(double theta) API broken?

For Graphics2D (AWT), theta is expected to be in radians. For GraphicsContext (JFX), the angle is expected to be expressed in degrees.

FXGraphics2D 1.3 contains the following code for this method:

Code: Select all

this.gc.rotate(theta * Math.PI / 180);

Shouldn't this actually be something like:

Code: Select all

this.gc.rotate(Math.toDegrees(theta));

What am I missing?

Thanks,
BB

[david.gilbert]

I think you are right, the conversion from radians to degrees looks wrong. I'll fix that.

[david.gilbert]

Thanks for your report, I committed this change for the next release:

https://github.com/jfree/fxgraphics2d/c ... fa2f57cd16

[bbolstad]

Awesome--thanks so much for the quick response!