Real time chart drawing with custom dataset?

[84923331]

I am trying to do some real time chart drawing with a custom dataset and am having troubles. Basically the chart is not updating as the values are added. I first tried adding something like a notifyall or notifylisteners however this did not work. I tried different ways of implementing a custom dataset like implementing an the XYDataset interface, extending TimeSeriesCollection. The custom datasets work fine when doing non-real-time charting. It's just that when the data-points are added by a thread while the program is running, they do not update properly, as in I have to manually zoom out and auto-range in order to see the new points added. I'll post my current test code showing how its failing, and example code not using a custom dataset I got from the internet which works perfectly and how I want it to look.

This is my test code:

Code: Select all

import java.awt.BorderLayout;
import java.awt.Container;

import javax.swing.JFrame;
import javax.swing.UIManager;
import javax.swing.UnsupportedLookAndFeelException;

import org.jfree.chart.ChartFactory;
import org.jfree.chart.ChartPanel;
import org.jfree.chart.JFreeChart;
import org.jfree.chart.axis.ValueAxis;
import org.jfree.chart.plot.PlotOrientation;
import org.jfree.chart.plot.XYPlot;
import org.jfree.data.xy.XYDataset;
import org.jfree.data.xy.XYSeries;
import org.jfree.data.xy.XYSeriesCollection;


public class Tests extends Thread {
	private MyDataset2 dataset;
	public Tests(){
	}
	public static void main(String[] args) {
		Tests tests = new Tests();
		tests.testrun();
	}
	public void testrun(){
		JFrame frame = new JFrame();
		
		/**
		 * Set the look and feel
		 */
		try {
			UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
		} catch (UnsupportedLookAndFeelException e) {
			e.printStackTrace();
		} catch (ClassNotFoundException e) {
			e.printStackTrace();
		} catch (InstantiationException e) {
			e.printStackTrace();
		} catch (IllegalAccessException e){
			e.printStackTrace();
		}
		
		frame.setSize(800,600);
		frame.setLocationRelativeTo(null);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		
		Container pane = frame.getContentPane();
		
		//XYSeries series = new XYSeries("random data");
		
		dataset = new MyDataset2();
        
        System.out.println(dataset.toString());
		
		JFreeChart chart = ChartFactory.createXYLineChart("test", "time", "data", dataset, PlotOrientation.VERTICAL, false, false, false);
		
		XYPlot plot = chart.getXYPlot();
		ValueAxis xaxis = plot.getDomainAxis();
		ValueAxis yaxis = plot.getRangeAxis();
		xaxis.setAutoRange(true);
		yaxis.setAutoRange(true);
		//xaxis.setFixedAutoRange(100);
		
		yaxis.setRange(0, 100);
		
		ChartPanel panel = new ChartPanel(chart);
		panel.setMouseZoomable(true, false);
		
		pane.add(panel, BorderLayout.CENTER);
		
		frame.setVisible(true);
		
		this.run();
	}
	public void run(){
		int count = 0;
		int xnum = 0;
		int ynum = 0;
		boolean increase = true;
		while(xnum < 10000){
			dataset.add(xnum, ynum);
			if(increase) ynum++;
			if(ynum > 100) increase = false;
			if(ynum < 0) increase = true;
			if(!increase) ynum--;
			xnum++;
			count++;
			if(count % 1000 == 0) System.out.println("count = " + count);
		}
	}
}

Code: Select all

import java.util.Vector;

import org.jfree.data.DomainInfo;
import org.jfree.data.DomainOrder;
import org.jfree.data.Range;
import org.jfree.data.RangeInfo;
import org.jfree.data.general.DatasetChangeListener;
import org.jfree.data.general.DatasetGroup;
import org.jfree.data.xy.AbstractIntervalXYDataset;
import org.jfree.data.xy.XYDataset;


public class MyDataset extends AbstractIntervalXYDataset implements XYDataset, DomainInfo, RangeInfo{
	Vector<Number> yValues;
	Vector<Number> xValues;
	Number xupper, xlower, yupper, ylower;
	public MyDataset() {
		yValues = new Vector<Number>();
		xValues = new Vector<Number>();
	}
	
	public void add(Number x, Number y) {
		xValues.add(x);
		yValues.add(y);
		if(xValues.size() == 1){
			xupper = xlower = x;
			yupper = ylower = y;
		}
		if(x.doubleValue() < xlower.doubleValue()) xlower = x;
		if(x.doubleValue() > xupper.doubleValue()) xupper = x;
		if(y.doubleValue() < ylower.doubleValue()) ylower = y;
		if(y.doubleValue() > yupper.doubleValue()) yupper = y;
	}
	
	public String toString() {
		String output = "xValues\tyValues\n";
		for(int i = 0; i < xValues.size(); i++) {
			output += xValues.get(i).toString() + '\t'
			+ yValues.get(i).toString() + '\n';
		}
		return output;
	}

	@Override
	public DomainOrder getDomainOrder() {
		return DomainOrder.NONE;
	}

	@Override
	public int getItemCount(int series) {
		if (series != 0) System.err.println("getItemCount illegal argument");
		return xValues.size();
	}

	@Override
	public Number getX(int series, int item) {
		if (series != 0) System.err.println("getx series out of bounds " + series);
		if (item > xValues.size()) System.err.println("getx item out of bounds " + item);
		return xValues.get(item);
	}

	@Override
	public double getXValue(int series, int item) {
		if (series != 0) System.err.println("getxvalue series out of bounds " + series);
		if (item > xValues.size()) System.err.println("getxvalue item out of bounds" + item);
		return xValues.get(item).doubleValue();
	}

	@Override
	public Number getY(int series, int item) {
		if (series != 0) System.err.println("gety series out of bounds " + series);
		if (item > xValues.size()) System.err.println("gety item out of bounds " + item);
		return yValues.get(item);
	}

	@Override
	public double getYValue(int series, int item) {
		if (series != 0) System.err.println("getYValue series out of bounds " + series);
		if (item > xValues.size()) System.err.println("getYValue item out of bounds " + item);
		return yValues.get(item).doubleValue();
	}

	@Override
	public int getSeriesCount() {
		return 1;
	}

	@Override
	public Comparable getSeriesKey(int arg0) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public int indexOf(Comparable arg0) {
		// TODO Auto-generated method stub
		return 0;
	}

	@Override
	public void addChangeListener(DatasetChangeListener arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public DatasetGroup getGroup() {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public void removeChangeListener(DatasetChangeListener arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void setGroup(DatasetGroup arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public Range getDomainBounds(boolean arg0) {
		return new Range(xlower.doubleValue(), xupper.doubleValue());
	}

	@Override
	public double getDomainLowerBound(boolean arg0) {
		return xlower.doubleValue();
	}

	@Override
	public double getDomainUpperBound(boolean arg0) {
		return xupper.doubleValue();
	}

	@Override
	public Range getRangeBounds(boolean arg0) {
		return new Range(xlower.doubleValue(), xupper.doubleValue());
	}

	@Override
	public double getRangeLowerBound(boolean arg0) {
		return ylower.doubleValue();
	}

	@Override
	public double getRangeUpperBound(boolean arg0) {
		return yupper.doubleValue();
	}

	@Override
	public Number getEndX(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public Number getEndY(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public Number getStartX(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public Number getStartY(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

}

Code: Select all

import java.util.Vector;
import org.jfree.data.DomainOrder;
import org.jfree.data.Range;
import org.jfree.data.general.DatasetChangeEvent;
import org.jfree.data.general.DatasetChangeListener;
import org.jfree.data.general.DatasetGroup;
import org.jfree.data.general.SeriesChangeEvent;
import org.jfree.data.time.TimeSeriesCollection;


public class MyDataset2 extends TimeSeriesCollection {

	/**
	 * 
	 */
	private static final long serialVersionUID = -5668723172608653606L;

	Vector<Number> yValues;
	Vector<Number> xValues;
	Number xupper, xlower, yupper, ylower;
	public MyDataset2() {
		yValues = new Vector<Number>();
		xValues = new Vector<Number>();
	}
	
	public void add(Number x, Number y) {
		xValues.add(x);
		yValues.add(y);
		if(xValues.size() == 1){
			xupper = xlower = x;
			yupper = ylower = y;
		}
		if(x.doubleValue() < xlower.doubleValue()) xlower = x;
		if(x.doubleValue() > xupper.doubleValue()) xupper = x;
		if(y.doubleValue() < ylower.doubleValue()) ylower = y;
		if(y.doubleValue() > yupper.doubleValue()) yupper = y;
		this.seriesChanged(new SeriesChangeEvent(0));
		this.notifyListeners(new DatasetChangeEvent(this, this));
	}
	
	public String toString() {
		String output = "xValues\tyValues\n";
		for(int i = 0; i < xValues.size(); i++) {
			output += xValues.get(i).toString() + '\t'
			+ yValues.get(i).toString() + '\n';
		}
		return output;
	}

	@Override
	public DomainOrder getDomainOrder() {
		return DomainOrder.NONE;
	}

	@Override
	public int getItemCount(int series) {
		if (series != 0) System.err.println("getItemCount illegal argument");
		return xValues.size();
	}

	@Override
	public Number getX(int series, int item) {
		if (series != 0) System.err.println("getx series out of bounds " + series);
		if (item > xValues.size()) System.err.println("getx item out of bounds " + item);
		return xValues.get(item);
	}

	@Override
	public double getXValue(int series, int item) {
		if (series != 0) System.err.println("getxvalue series out of bounds " + series);
		if (item > xValues.size()) System.err.println("getxvalue item out of bounds" + item);
		return xValues.get(item).doubleValue();
	}

	@Override
	public Number getY(int series, int item) {
		if (series != 0) System.err.println("gety series out of bounds " + series);
		if (item > xValues.size()) System.err.println("gety item out of bounds " + item);
		return yValues.get(item);
	}

	@Override
	public double getYValue(int series, int item) {
		if (series != 0) System.err.println("getYValue series out of bounds " + series);
		if (item > xValues.size()) System.err.println("getYValue item out of bounds " + item);
		return yValues.get(item).doubleValue();
	}

	@Override
	public int getSeriesCount() {
		return 1;
	}

	@Override
	public Comparable getSeriesKey(int arg0) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public int indexOf(Comparable arg0) {
		// TODO Auto-generated method stub
		return 0;
	}

	@Override
	public void addChangeListener(DatasetChangeListener arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public DatasetGroup getGroup() {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public void removeChangeListener(DatasetChangeListener arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public void setGroup(DatasetGroup arg0) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public Range getDomainBounds(boolean arg0) {
		return new Range(xlower.doubleValue(), xupper.doubleValue());
	}

	@Override
	public double getDomainLowerBound(boolean arg0) {
		return xlower.doubleValue();
	}

	@Override
	public double getDomainUpperBound(boolean arg0) {
		return xupper.doubleValue();
	}

	@Override
	public Number getEndX(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public Number getEndY(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public Number getStartX(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

	@Override
	public Number getStartY(int arg0, int arg1) {
		// TODO Auto-generated method stub
		return null;
	}

}

This is the example code which works:

Code: Select all

/* ===========================================================
 * JFreeChart : a free chart library for the Java(tm) platform
 * ===========================================================
 *
 * (C) Copyright 2000-2004, by Object Refinery Limited and Contributors.
 *
 * Project Info:  http://www.jfree.org/jfreechart/index.html
 *
 * This library is free software; you can redistribute it and/or modify it under the terms
 * of the GNU Lesser General Public License as published by the Free Software Foundation;
 * either version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
 * without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 * See the GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License along with this
 * library; if not, write to the Free Software Foundation, Inc., 59 Temple Place, Suite 330,
 * Boston, MA 02111-1307, USA.
 *
 * [Java is a trademark or registered trademark of Sun Microsystems, Inc. 
 * in the United States and other countries.]
 *
 * --------------------
 * DynamicDataDemo.java
 * --------------------
 * (C) Copyright 2002-2004, by Object Refinery Limited.
 *
 * Original Author:  David Gilbert (for Object Refinery Limited).
 * Contributor(s):   -;
 *
 * $Id: DynamicDataDemo.java,v 1.12 2004/05/07 16:09:03 mungady Exp $
 *
 * Changes
 * -------
 * 28-Mar-2002 : Version 1 (DG);
 *
 */

import java.awt.BorderLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

import javax.swing.JButton;
import javax.swing.JPanel;

import org.jfree.chart.ChartFactory;
import org.jfree.chart.ChartPanel;
import org.jfree.chart.JFreeChart;
import org.jfree.chart.axis.ValueAxis;
import org.jfree.chart.plot.XYPlot;
import org.jfree.data.time.Millisecond;
import org.jfree.data.time.TimeSeries;
import org.jfree.data.time.TimeSeriesCollection;
import org.jfree.data.xy.XYDataset;
import org.jfree.ui.ApplicationFrame;
import org.jfree.ui.RefineryUtilities;

/**
 * A demonstration application showing a time series chart where you can dynamically add
 * (random) data by clicking on a button.
 *
 */
public class DynamicDataDemo extends ApplicationFrame implements ActionListener {

    /** The time series data. */
    private TimeSeries series;

    /** The most recent value added. */
    private double lastValue = 100.0;

    /**
     * Constructs a new demonstration application.
     *
     * @param title  the frame title.
     */
    public DynamicDataDemo(final String title) {

        super(title);
        this.series = new TimeSeries("Random Data", Millisecond.class);
        final TimeSeriesCollection dataset = new TimeSeriesCollection(this.series);
        final JFreeChart chart = createChart(dataset);

        final ChartPanel chartPanel = new ChartPanel(chart);
        final JButton button = new JButton("Add New Data Item");
        button.setActionCommand("ADD_DATA");
        button.addActionListener(this);

        final JPanel content = new JPanel(new BorderLayout());
        content.add(chartPanel);
        content.add(button, BorderLayout.SOUTH);
        chartPanel.setPreferredSize(new java.awt.Dimension(500, 270));
        setContentPane(content);

    }

    /**
     * Creates a sample chart.
     * 
     * @param dataset  the dataset.
     * 
     * @return A sample chart.
     */
    private JFreeChart createChart(final XYDataset dataset) {
        final JFreeChart result = ChartFactory.createTimeSeriesChart(
            "Dynamic Data Demo", 
            "Time", 
            "Value",
            dataset, 
            true, 
            true, 
            false
        );
        final XYPlot plot = result.getXYPlot();
        ValueAxis axis = plot.getDomainAxis();
        axis.setAutoRange(true);
        axis.setFixedAutoRange(60000.0);  // 60 seconds
        axis = plot.getRangeAxis();
        axis.setRange(0.0, 200.0); 
        return result;
    }
    
    // ****************************************************************************
    // * JFREECHART DEVELOPER GUIDE                                               *
    // * The JFreeChart Developer Guide, written by David Gilbert, is available   *
    // * to purchase from Object Refinery Limited:                                *
    // *                                                                          *
    // * http://www.object-refinery.com/jfreechart/guide.html                     *
    // *                                                                          *
    // * Sales are used to provide funding for the JFreeChart project - please    * 
    // * support us so that we can continue developing free software.             *
    // ****************************************************************************
    
    /**
     * Handles a click on the button by adding new (random) data.
     *
     * @param e  the action event.
     */
    public void actionPerformed(final ActionEvent e) {
        if (e.getActionCommand().equals("ADD_DATA")) {
            final double factor = 0.90 + 0.2 * Math.random();
            this.lastValue = this.lastValue * factor;
            final Millisecond now = new Millisecond();
            System.out.println("Now = " + now.toString());
            this.series.add(new Millisecond(), this.lastValue);
        }
    }
    public void addvalue(){
    	final double factor = 0.90 + 0.2 * Math.random();
        this.lastValue = this.lastValue * factor;
        final Millisecond now = new Millisecond();
        System.out.println("Now = " + now.toString());
        this.series.addOrUpdate(new Millisecond(), this.lastValue);
    }

    /**
     * Starting point for the demonstration application.
     *
     * @param args  ignored.
     */
    public static void main(final String[] args) {

        final DynamicDataDemo demo = new DynamicDataDemo("Dynamic Data Demo");
        demo.pack();
        RefineryUtilities.centerFrameOnScreen(demo);
        demo.setVisible(true);
        while(true){
        	demo.addvalue();
        }
    }

}

I am using jfreechart version 1.0.13 with java 6

[paradoxoff]

You have overwritten the addChangeListener(DatasetChangeListener listener) method with an empty method body. Thus, you will never register a DatasetChangeListener with your dataset.